Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Token Order wrong in special cases #852

Closed
brodmo opened this issue Dec 17, 2022 · 1 comment
Closed

Java Token Order wrong in special cases #852

brodmo opened this issue Dec 17, 2022 · 1 comment
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change

Comments

@brodmo
Copy link
Contributor

brodmo commented Dec 17, 2022

Screenshot 2022-12-17 at 20 00 33

Screenshot 2022-12-17 at 20 02 27

This is because all the tokens corresponding to a construct are generated all at once and then the super method is called. This results in the wrong token order. The correct way would be to re-implement the super method as is done in `visitIf`.
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change good first issue Good first issue for new contributors. New contributors are welcome! labels Dec 19, 2022
This was referenced Dec 19, 2022
Closed
Merged
@tsaglam tsaglam added the language PR / Issue deals (partly) with new and/or existing languages for JPlag label Dec 20, 2022
@tsaglam tsaglam removed the good first issue Good first issue for new contributors. New contributors are welcome! label Jan 17, 2023
@tsaglam
Copy link
Member

tsaglam commented Jan 17, 2023

Closed by #830.

@tsaglam tsaglam closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsaglam @brodmo