Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make search results toggle or clear node path #81

Closed
dranitski opened this issue May 17, 2022 · 2 comments
Closed

make search results toggle or clear node path #81

dranitski opened this issue May 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@dranitski
Copy link

dranitski commented May 17, 2022

Hi! It is sometimes confusing if I have one node selected and toggle search, then cycle through search results.
I think "selected node path" should be dropped at least, and it will be great if "selected node path" will follow the current selected search result, it would be super handy.

image

Case:
user searches for word "social" in a big json. Cycling through search results with auto-selecting current search result would be super handy since user could easily (without extra X clicks) see which json section (node path) is a parent of current search result.

Thanks in advance!

@josdejong
Copy link
Owner

Thanks, that makes sense.

Right now the navigation path shows where the current selection is. Probably the best solution is to clear the selection when cycling through the search results, and show the path of the active search result instead.

@josdejong josdejong added the enhancement New feature or request label May 17, 2022
@josdejong
Copy link
Owner

I've now implemented and published a fix that clears the navigation path whilst iterating through search results. Keeping the selection in sync with the active search results works out a bit odd (mixing two different things). Another future improvement could be to implement Ctrl+Click to switch focus from the SearchBox to the active search result for real.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants