API claims brand new e-mailaddress is already in use

[skoop]

I am in the process of migrating my email from Google to Proton. As such, I wanted to change the emailaddress associated with my joind.in account. But as I tried to update my emailaddress, I ran into an error:

An error occurred: Your profile update was not accepted. The server reports: ["That email is already associated with another account"]

I found two places in the `UserController where this happens: lines 183 and 337. I don't have a local Vagrant, so I could not reprodure locally to pinpoint which of the two is erroring out. The code around both does look like it should work though.

I discussed this with @heiglandreas, I might give it a try next week to reproduce locally and send a PR. If anyone can find the issue before that, great! If not, I'll have a look next week.

[skoop]

Oh, also: I tried logging out and do "forgotten username" to test and see if for some reason an account would exist with the new emailaddress, but then it doesn't recognize the emailaddress. So there should not actually be an account with this emailaddress.

[iansltx]

I'm able to repro this.

This appears to have gotten broken in 4ebe7b5, as a truthiness check (which will only be true if the array is nonzero-length) was replaced with a key existence check (which will be true if the array is zero-length).

Checking for other cases of this now and will fix that I find shortly.

[iansltx]

Fix for this is rolling out now. I'll verify on my own account and post here when that's done.

[iansltx]

Yep, this is now fixed!

[skoop]

Confirmed! Thanks, that was quick!