Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Update to 1.52.1 extension? #2

Open
macOS-Mavericks opened this issue Aug 28, 2021 · 2 comments
Open

Update to 1.52.1 extension? #2

macOS-Mavericks opened this issue Aug 28, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@macOS-Mavericks
Copy link

Any chance you can update this please to the new 1.52.1 version of Bitwarden?

@3j14
Copy link
Owner

3j14 commented Aug 29, 2021

Sure! I will try to port the newest version of the browser extension soon. Currently working on my Bachelor's thesis so won't have much time to work on this. But I'll do my best 😄

@3j14 3j14 self-assigned this Aug 29, 2021
@3j14 3j14 added the enhancement New feature or request label Aug 29, 2021
@3j14
Copy link
Owner

3j14 commented Oct 3, 2021

I worked on this for a few days now and I am afraid I have to conclude that this will not be possible. Starting from version 1.49.0 with commit bitwarden/browser a2540ab , the Bitwarden browser extension uses the new Safari Web Exentsions API. This is a big leap forward for the extension itself and means that the Bitwarden team does not have to carry around extra code for the Safari extension which previously worked differently as compared to the Chrome/Firefox version. At the same time, this introduces breaking changes in the way the JavaScript code interacts with the application. Previously a user content controller was responsible for messages send by JavaScript to the application/system

/~https://github.com/jnsdrtlf/bitwarden-menubar/blob/c5116e8a1086bce5638eed0c3bd7320c7d6aab09/Bitwarden/ContentView.swift#L44

Now, this is done with the new SafariWebExtensionHandler introduced by the Bitwarden team. For now, I was unable to attach this extension handler outside of a Safari extension in a normal macOS trap application and thereby unable to intersect messages send by the JavaScript components of the extension.

Maybe someone with more expertise in this area can come along and help me out implementing the message handler. The current state of the application only displays a spinning loader as some JavaScript components fail to initialise correctly.

3j14 added a commit that referenced this issue Mar 3, 2022
@3j14 3j14 added the wontfix This will not be worked on label Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants