Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.each no-done-callback false positive in version 24.1.1 #709

Closed
CrOrc opened this issue Nov 12, 2020 · 1 comment · Fixed by #708
Closed

test.each no-done-callback false positive in version 24.1.1 #709

CrOrc opened this issue Nov 12, 2020 · 1 comment · Fixed by #708
Labels
bug each support Relates to supporting the `each` method released

Comments

@CrOrc
Copy link

CrOrc commented Nov 12, 2020

Plugin version: 24.1.1
Last working version: 24.1.0
Rule jest/no-done-callback has false positives with test.each

test.each`
  size   | chunkSize    | sum
  ${50}  | ${undefined} | ${(50 * 49) / 2}
`(
  "sums array indices of size $size with chunkSize=$chunkSize => $sum",
  async ({size, chunkSize, sum}) => {
    await expect(
      reduce(new Array(size).fill(0).map((v, index) => index), (ret, it, index) => ret + index, 0, chunkSize)
    ).resolves.toBe(sum);
  }
);
@github-actions
Copy link

🎉 This issue has been resolved in version 24.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug each support Relates to supporting the `each` method released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants