Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to alpine-3.14 #3303

Closed
wants to merge 1 commit into from
Closed

Upgrade to alpine-3.14 #3303

wants to merge 1 commit into from

Conversation

nwnt
Copy link
Contributor

@nwnt nwnt commented Oct 5, 2021

Short description of the changes

  • Bumping the version of the image from alpine-3.13 to alpine-3.14 for both the root and the go images.

@nwnt nwnt requested a review from a team as a code owner October 5, 2021 04:56
@nwnt nwnt requested a review from vprithvi October 5, 2021 04:56
Signed-off-by: Nont <nontkrub@gmail.com>
@yurishkuro yurishkuro enabled auto-merge (squash) October 5, 2021 05:13
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3303 (7997e16) into master (b5c451a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
+ Coverage   95.98%   96.00%   +0.01%     
==========================================
  Files         259      259              
  Lines       15434    15434              
==========================================
+ Hits        14814    14817       +3     
+ Misses        526      523       -3     
  Partials       94       94              
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
plugin/storage/integration/integration.go 79.28% <0.00%> (+0.39%) ⬆️
cmd/query/app/server.go 95.58% <0.00%> (+1.47%) ⬆️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c451a...7997e16. Read the comment docs.

@jpkrohling
Copy link
Contributor

@Nontw, weird things happen when PRs are opened from master (yours), targeting master (ours). Could you please re-create this PR from another local branch? Something like this:

git checkout master
git checkout -b update-alpine
git push

Then, open the PR based on your update-alpine branch.

@nwnt
Copy link
Contributor Author

nwnt commented Oct 5, 2021

@jpkrohling, definitely I can do that. Thank you very much for the feedback! Let me close this one, make the correction and resubmit real quick.

@nwnt nwnt closed this Oct 5, 2021
auto-merge was automatically disabled October 5, 2021 12:09

Pull request was closed

@nwnt nwnt mentioned this pull request Oct 5, 2021
@nwnt
Copy link
Contributor Author

nwnt commented Oct 5, 2021

Done! Created 3304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants