fix: Print explicit error if use with babel 6 is attempted #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
approved these changes
May 15, 2019
|
@bcoe it started to actually fail when istanbul-lib-instrument gained support for class properties. See #206 for an example of the error currently produced. This PR will cause the error to directly say that Babel 7 is required rather than 'You gave us a visitor for the node type "ClassPrivateProperty" but it's not a valid type'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify the src -> lib transpile to only process ESM -> CJS, nothing else from
@babel/preset-envis needed by node.js 6.