Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test: TestSendingLargeMessages #625

Closed
lidel opened this issue Jun 21, 2024 · 0 comments · Fixed by #634
Closed

flaky test: TestSendingLargeMessages #625

lidel opened this issue Jun 21, 2024 · 0 comments · Fixed by #634
Labels
help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work

Comments

@lidel
Copy link
Member

lidel commented Jun 21, 2024

Ref. /~https://github.com/ipfs/boxo/actions/runs/9606108784/job/26495046051?pr=624#step:14:62

--- FAIL: TestSendingLargeMessages (0.13s)
      messagequeue_test.go:540: expected 4 messages to be sent, got 3

It usually fails on Windows and go next
@lidel lidel added help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work labels Jun 21, 2024
@lidel lidel mentioned this issue Jun 21, 2024
Closed
@lidel lidel mentioned this issue Jul 2, 2024
Merged
@lidel lidel closed this as completed in #634 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(bitswap): performance improvements ipfs/boxo
1 participant
@lidel