fix: Change hasHostListenerAttached from var to protoype property #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @christian-bromann / @tanner-reits, |
|
@dwirz I believe members of the team are away atm. I'm sure they'll review when able |
christian-bromann
approved these changes
Dec 6, 2024
christian-bromann
approved these changes
Dec 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thank you @christian-bromann! 🤗 |
dwirz
deleted the
fix/change-listener-attached-flag-from-global-var-to-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When a component with event listeners is mounted multiple times, the event listeners are only registered for the first instance. This leads to unexpected behavior for subsequent instances.
GitHub Issue: fixes #6066
What is the new behavior?
Event listener registration is now handled on a per-instance basis. This ensures that each mounted instance of the component registers and manages its event listeners independently.
Documentation
No updates required. 😊
Does this introduce a breaking change?
Testing
A new test has been added to verify that event listeners are correctly registered and fired when a component is mounted twice. This ensures consistent behavior across instances.
Other information
The bug was introduced as a result of change #6052.