-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: vite v5 warning #5008
Labels
Bug: Validated
This PR or Issue is verified to be a bug within Stencil
Comments
Thanks! |
rwaskiewicz
added a commit
that referenced
this issue
Nov 3, 2023
remove `/*@__PURE__*/` comment pragma warnings from vite v5/rollup v4 from a pragma that was applied to a variable assignment that rollup can't understand. prior to this fix, building a stencil/ionic project using stencil would result in a warning in the console similar to the following: ``` vite v5.0.0-beta.14 building for production... node_modules/.pnpm/@Stencil+core@4.7.0/node_modules/@stencil/core/internal/client/index.js (3800:17) A comment "/*@__PURE__*/" in "node_modules/.pnpm/@Stencil+core@4.7.0/node_modules/@stencil/core/internal/client/index.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues. ``` Stencil-996 bug: vite v5 warning fixes: #5008
2 tasks
@aeharding Can you give the following dev builds a try when you get a chance?
|
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 6, 2023
remove `/*@__PURE__*/` comment pragma warnings from vite v5/rollup v4 from a pragma that was applied to a variable assignment that rollup can't understand. prior to this fix, building a stencil/ionic project using stencil would result in a warning in the console similar to the following: ``` vite v5.0.0-beta.14 building for production... node_modules/.pnpm/@Stencil+core@4.7.0/node_modules/@stencil/core/internal/client/index.js (3800:17) A comment "/*@__PURE__*/" in "node_modules/.pnpm/@Stencil+core@4.7.0/node_modules/@stencil/core/internal/client/index.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues. ``` Stencil-996 bug: vite v5 warning fixes: #5008
The fix for this went out as a part of today's v4.7.2 release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Stencil Version
4.7.0
Current Behavior
When building an Ionic project with Vite v5 (beta 14), I get the following warning:
Expected Behavior
No warning
System Info
npx stencil info
doesn't work - this is an Ionic project with stencil used under the hood I assumeionic info
:Steps to Reproduce
pnpm i
pnpm build
Code Reproduction URL
/~https://github.com/aeharding/stencil-warning
Additional Information
No response
The text was updated successfully, but these errors were encountered: