-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Never Mock CommonModule standalone directives #5047
Labels
Comments
Hi @evtk, could you provide an example of a failing test? As an option, you can use |
satanTime
added a commit
to satanTime/ng-mocks
that referenced
this issue
Mar 5, 2023
satanTime
added a commit
to satanTime/ng-mocks
that referenced
this issue
Mar 5, 2023
satanTime
added a commit
that referenced
this issue
Mar 5, 2023
docs(CommonModule): keeping standalone declarations #5047
v14.7.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems. |
awesome, many thanks. Works like charm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature or problem you'd like to solve
I'm currently migrating my Angular app to standalone components and I noticed a lot of UT's failing due to the fact that the standalone Directives from the CommonModule are all mocked.
If you use the
CommonModule
, this issue doesn't occur, because theCommonModule
will never be mocked.119dd80#diff-681237701f19323be249b4715554476ddf90b5f2f81ebbf06e8a7206344048aa
Proposed solution
Can all the standalone directives from the
CommonModule
also be excluded from mocking. This will prevent to do ain every UT. Many thanks!
Additional context
Posted this on the gitter as well: https://app.gitter.im/#/room/#ng-mocks_community:gitter.im/$B5OT4_mO-IlFcQHZc7Pg_rYyxm-OxSJBdPx1BNPVkAM
The text was updated successfully, but these errors were encountered: