Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create a client against icat.server 6.1.0-SNAPSHOT: icat.exception.ICATParameterError: Parameter is not an ICAT entity #153

Closed
louise-davies opened this issue May 20, 2024 · 4 comments · Fixed by icatproject/icat.server#334
Labels
compatibility Issues about compatibility with libraries or other packages wontfix This will not be worked on

Comments

@louise-davies
Copy link

Hello,

The new icat.server snapshot (6.1.0-SNAPSHOT) no longer works with python-icat, when trying to create a client we get an error from getEntityInfo: icat.exception.ICATParameterError: Parameter is not an ICAT entity. @ajkyffin has pointed out that python-icat queries for the entity info of the "Parameter" entity, which isn't a real entity in icat.server (see /~https://github.com/icatproject/python-icat/blob/develop/src/icat/entities.py#L253). The commit on icat.server which changed what is returned from getEntityInfo is here: icatproject/icat.server@7420ced

Alan could modify icat.server to return entity info for "Parameter" to keep in line with old behaviour, but that seems like the wrong thing to do and instead we should not expect to have "Parameter" be valid for getting entity info

@RKrahl RKrahl added the compatibility Issues about compatibility with libraries or other packages label May 20, 2024
@RKrahl
Copy link
Member

RKrahl commented May 20, 2024

But then, this change in icat.server is a breaking change that should be discussed in the community and certainly not be made in a minor release.

@ajkyffin
Copy link

My intention was not to make any breaking changes so I'll add back the ability to get entity info for Parameter into icat.server.

@RKrahl
Copy link
Member

RKrahl commented May 20, 2024

I guess, we can discuss this in the collaboration meeting next week.

In the meanwhile, I mark this one with question tag, pending this discussion.

@RKrahl RKrahl added the question Further information is requested label May 20, 2024
@RKrahl RKrahl added wontfix This will not be worked on and removed question Further information is requested labels Jun 2, 2024
@RKrahl
Copy link
Member

RKrahl commented Jun 2, 2024

As discussed in the collaboration meeting this week, icat.server will for the time being continue to deliver entity info for the abstract class Parameter. There is thus no need to change python-icat in this point.

@RKrahl RKrahl closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issues about compatibility with libraries or other packages wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants