Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google preset not running #11

Closed
willhowlett opened this issue Oct 24, 2019 · 2 comments
Closed

Google preset not running #11

willhowlett opened this issue Oct 24, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@willhowlett
Copy link

Describe the bug
It seems that when using the Google preset option no google specific tests run

To Reproduce
sdtt --url https://www.techradar.com --presets "Google"

Expected behavior
Tests run under Google heading (as happens when using Facebook, Twitter )

Screenshots
Screen Shot 2019-10-24 at 10 47 46

@willhowlett willhowlett added the bug Something isn't working label Oct 24, 2019
@iaincollins
Copy link
Owner

Oh! I missed this somehow. Thank you for the bug report!

It looks like:

  1. It is not finding any schemas is knows about that Google consumes. Currently it supports about a dozen of the schemas Google uses, but currently they are mostly various different article types. It doesn't validate otherGoogle supported schemas yet, like Organization, but it should.

  2. It doesn't reflect what was done meaningfully in the output - it should probably do something like output how many known and unknown Google schema types it found, so that it is more transparent about what was found / not found.

Does this explanation make sense?

Having it meet your expectations of the "expected behaviour" seems very reasonable.

Happy to take details of feature requests for the sort of behaviour you would like to see.

@iaincollins iaincollins modified the milestones: Version 4.0, Version 3.0 Mar 6, 2020
@iaincollins
Copy link
Owner

This should be resolved with the release of version 4.0.

I've added explicit support for the above schemas. It seems they both only have "optional" properties in Google, so I added support for checking optional properties in version 4.0.

The way any Schema.org properties are detected and the results displayed has also changed, so it should also work better for people using other schemas, even ones the tool does not know that Google explicitly supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants