This repository has been archived by the owner on May 13, 2022. It is now read-only.
Contract creation nonce for predictable addresses #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasdavis
changed the title
silasdavis
force-pushed
the
develop
branch
5 times, most recently
from
381ed8a to
d0474d7
Compare
This gives us more predictable addresses for proposal mechanism. Signed-off-by: Silas Davis <silas@monax.io>
silasdavis
changed the title
silasdavis
pushed a commit
to silasdavis/burrow
that referenced
this pull request
Mar 9, 2019
Contract creation nonce for predictable sequence numbers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the TxHash along with an alternative sequence number within the VM to generate new contract addresses. The vm therefore no longer modifies input account sequence numbers which means the input account sequence number just always goes up by one as a result of: /~https://github.com/hyperledger/burrow/blob/develop/execution/execution.go#L414 and not every time a contract is created.
Provided the TxHash is unique with high probability then this still avoid collisions in generated addresses. It does mean that generated addresses are not predictable in the same way. We d not currently use this fact, but I am concerned that may be desirable (will look at other EVMs implementations).