Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove high-level pooling Client #2841

Closed
2 tasks done
seanmonstar opened this issue May 20, 2022 · 1 comment · Fixed by #2941
Closed
2 tasks done

Remove high-level pooling Client #2841

seanmonstar opened this issue May 20, 2022 · 1 comment · Fixed by #2941
Assignees
@seanmonstar
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

seanmonstar commented May 20, 2022 •
edited
Loading

The hyper::Client and support modules hyper::client::connect should be removed from hyper, and parts should reappear in hyper-util.
@seanmonstar seanmonstar added A-client Area: client. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. labels May 20, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 20, 2022
@seanmonstar seanmonstar moved this to Todo in hyper 1.0 Jun 15, 2022
@dswij dswij mentioned this issue Jul 24, 2022
Closed
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Jul 26, 2022
@seanmonstar seanmonstar changed the title Move high-level pooling Client to hyper-util Remove high-level pooling Client Aug 12, 2022
@seanmonstar seanmonstar self-assigned this Aug 12, 2022
@seanmonstar seanmonstar mentioned this issue Aug 13, 2022
Merged
Repository owner moved this from In Progress to Done in hyper 1.0 Aug 15, 2022
@cameronelliott
Copy link

cameronelliott commented Aug 16, 2022 •
edited
Loading

@seanmonstar I was going to submit a one line PR to the docs of hyper::client::Client
along the lines of "Client supports concurrent requests to multiple different host names".
(I wrote a simple test harness & used two different slow http servers to verify how this worked)

But I just discovered this PR+issue. (substantial refactoring)

For me, it was hinted, but not clear that I could use Client concurrently for different hostnames.
I really think the docs would benefit from an explicit statement regarding this.
Let me know if I can help on that somehow.

@memoryruins memoryruins mentioned this issue Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanmonstar seanmonstar

Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat(client): remove higher-level hyper::Client hyperium/hyper
2 participants
@seanmonstar @cameronelliott