fix(ssg): Preserve the SSR server instance during page rendering (#209)

* test(ssg): handle a page with dynamic imports * fix(ssg): keep server instance during render the pages * yarn changeset
honojs · Jan 9, 2025 · 9a39a51 · 9a39a51
1 parent 2179833
commit 9a39a51
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 1 deletion.
diff --git a/.changeset/curly-cherries-tell.md b/.changeset/curly-cherries-tell.md
@@ -0,0 +1,5 @@
+---
+'@hono/vite-ssg': patch
+---
+
+Preserve the SSR server instance during page rendering
diff --git a/packages/ssg/src/ssg.ts b/packages/ssg/src/ssg.ts
@@ -56,7 +56,6 @@ export const ssgBuild = (options?: SSGOptions): Plugin => {
         build: { ssr: true },
       })
       const module = await server.ssrLoadModule(entry)
-      server.close()
 
       const app = module['default'] as Hono
 
@@ -84,6 +83,8 @@ export const ssgBuild = (options?: SSGOptions): Plugin => {
         { dir: outDir }
       )
 
+      server.close()
+
       if (!result.success) {
         throw result.error
       }

diff --git a/packages/ssg/test/app.ts b/packages/ssg/test/app.ts
@@ -6,4 +6,10 @@ app.get('/', (c) => {
   return c.html('<html><body><h1>Hello!</h1></body></html>')
 })
 
+app.get('/dynamic-import', async (c) => {
+  // @ts-expect-error
+  const module = await import('./sample.js')
+  return c.text('Dynamic import works: ' + module.default)
+})
+
 export default app
diff --git a/packages/ssg/test/sample.js b/packages/ssg/test/sample.js
@@ -0,0 +1 @@
+export default "sample!";
diff --git a/packages/ssg/test/ssg.test.ts b/packages/ssg/test/ssg.test.ts
@@ -9,6 +9,7 @@ describe('ssgPlugin', () => {
   const entryFile = './test/app.ts'
   const outDir = path.resolve(testDir, 'dist')
   const outputFile = path.resolve(outDir, 'index.html')
+  const outputFileWithDynamicImport = path.resolve(outDir, 'dynamic-import.txt')
 
   beforeAll(() => {
     fs.mkdirSync(testDir, { recursive: true })
@@ -38,6 +39,11 @@ describe('ssgPlugin', () => {
     const output = fs.readFileSync(outputFile, 'utf-8')
     expect(output).toBe('<html><body><h1>Hello!</h1></body></html>')
 
+    expect(fs.existsSync(outputFileWithDynamicImport)).toBe(true)
+
+    const outputDynamicImport = fs.readFileSync(outputFileWithDynamicImport, 'utf-8')
+    expect(outputDynamicImport).toBe('Dynamic import works: sample!')
+
     // Should not output files corresponding to a virtual entry
     expect(fs.existsSync(path.resolve(outDir, 'assets'))).toBe(false)
   })