feat(load-balancer): handle planned targets exceedings max targets #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catches the error condition before we even make a request to the API. Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
jooola
reviewed
Nov 29, 2023
|
Quick fix to the original issue description, the current behaviour is exactly the same, but we send less API requests in this case. If an |
jooola
approved these changes
Nov 29, 2023
4 tasks
apricote
pushed a commit
that referenced
this pull request
Dec 1, 2023
🤖 I have created a release *beep* *boop* --- ## [1.19.0-rc.0](v1.18.0...v1.19.0-rc.0) (2023-12-01) ### Features * **chart:** add daemonset and node selector ([#537](#537)) ([a94384f](a94384f)) * **config:** stricter validation for settings `HCLOUD_LOAD_BALANCERS_ENABLED`, `HCLOUD_METRICS_ENABLED` & `HCLOUD_NETWORK_ROUTES_ENABLED` ([#546](#546)) ([335a2c9](335a2c9)) * **helm:** remove "v" prefix from chart version ([#565](#565)) ([f11aa0d](f11aa0d)), closes [#529](#529) * **load-balancer:** handle planned targets exceedings max targets ([#570](#570)) ([8bb131f](8bb131f)) * remove unused variable NODE_NAME ([#545](#545)) ([a659408](a659408)) * **robot:** handle ratelimiting with constant backoff ([#572](#572)) ([2ddc201](2ddc201)) * support for Robot servers ([#561](#561)) ([65dea11](65dea11)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please).
apricote
added a commit
that referenced
this pull request
Dec 7, 2023
## [1.19.0](v1.18.0...v1.19.0) (2023-12-07) ### Features * **chart:** add daemonset and node selector ([#537](#537)) ([a94384f](a94384f)) * **config:** stricter validation for settings `HCLOUD_LOAD_BALANCERS_ENABLED`, `HCLOUD_METRICS_ENABLED` & `HCLOUD_NETWORK_ROUTES_ENABLED` ([#546](#546)) ([335a2c9](335a2c9)) * **helm:** remove "v" prefix from chart version ([#565](#565)) ([f11aa0d](f11aa0d)), closes [#529](#529) * **load-balancer:** handle planned targets exceedings max targets ([#570](#570)) ([8bb131f](8bb131f)) * remove unused variable NODE_NAME ([#545](#545)) ([a659408](a659408)) * **robot:** handle ratelimiting with constant backoff ([#572](#572)) ([2ddc201](2ddc201)) * support for Robot servers ([#561](#561)) ([65dea11](65dea11))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches the error condition before we even make a request to the API. This causes less requests to be sent to the Hetzner Cloud API.
This does not change the behavior, as we just log & continue right now if we encounter a
ErrorCodeResourceLimitExceededwhile adding the target. Both cases are just visible in the HCCM logs (see #569 for improvements in that regard).