Merge pull request #3096 from satanTime/issues/3095

fix(core): preventing recursion of self pointers #3095

.eslintignore

@@ -19,3 +19,4 @@ tests-failures/
 tmp/
 
 **/*.sh
+**/.nvmrc

.prettierignore

@@ -17,3 +17,4 @@ test-reports/
 tmp/
 
 **/*.sh
+**/.nvmrc

docker-compose.yml

@@ -110,6 +110,8 @@ services:
     working_dir: /app
     volumes:
       - ./e2e/a9:/app
+      - gyp:/root/.node-gyp
+      - npm:/root/.npm
     command:
       - npm
       - install

e2e/a10/.nvmrc

@@ -0,0 +1 @@
+12.22.12

e2e/a11/.nvmrc

@@ -0,0 +1 @@
+12.22.12

e2e/a12/.nvmrc

@@ -0,0 +1 @@
+12.22.12

e2e/a13/.nvmrc

@@ -0,0 +1 @@
+12.22.12

e2e/a14/.nvmrc

@@ -0,0 +1 @@
+16.16.0

e2e/a5es2015/.nvmrc

@@ -0,0 +1 @@
+6.17.1

e2e/a6/.nvmrc

@@ -0,0 +1 @@
+8.17.0

e2e/a7/.nvmrc

@@ -0,0 +1 @@
+8.17.0

e2e/a8/.nvmrc

@@ -0,0 +1 @@
+10.24.1

e2e/a9/.nvmrc

@@ -0,0 +1 @@
+12.22.12

e2e/jasmine/.nvmrc

@@ -0,0 +1 @@
+16.16.0

e2e/jest/.nvmrc

@@ -0,0 +1 @@
+16.16.0

e2e/min/.nvmrc

@@ -0,0 +1 @@
+16.16.0

e2e/nx/.nvmrc

@@ -0,0 +1 @@
+16.16.0

libs/ng-mocks/src/lib/common/ng-mocks-global-overrides.ts

@@ -87,10 +87,10 @@ const generateTouches = (moduleDef: Partial<Record<dependencyKeys, any>>, touche
       if (!Object.prototype.hasOwnProperty.call(def, '__ngMocksTouches')) {
         const local = new Set<any>();
         const meta = coreReflectMeta(def);
+        coreDefineProperty(def, '__ngMocksTouches', local, false);
         if (meta) {
           generateTouches(meta, local);
         }
-        coreDefineProperty(def, '__ngMocksTouches', local, false);
       }
 
       mapValues(def.__ngMocksTouches, touches);

package.json

@@ -6,6 +6,7 @@
     "postinstall": "husky install",
     "release": "export $(cat .env) && semantic-release",
     "build": "npm run clean && npm run build:webpack && npm run build:types && cp CHANGELOG.md dist/libs/ng-mocks && cp README.md dist/libs/ng-mocks && cp LICENSE dist/libs/ng-mocks && cp libs/ng-mocks/package.json dist/libs/ng-mocks/package.json && cp libs/ng-mocks/migrations.json dist/libs/ng-mocks/migrations.json && cp -R examples dist/libs/ng-mocks",
+    "build:dev": "MODE=development npm run build",
     "build:webpack": "webpack",
     "build:types": "dts-bundle-generator --no-banner -o ./dist/libs/ng-mocks/index.d.ts --project ./libs/ng-mocks/tsconfig.build.cjs.json --no-check --export-referenced-types=false ./libs/ng-mocks/src/index.ts",
     "build:all": "npm run lint && npm run build && npm run test",

renovate.json

@@ -22,7 +22,7 @@
     },
 
     {
-      "packagePatterns": ["satantime/puppeteer-node", "@types/node"],
+      "packagePatterns": ["satantime/puppeteer-node", "@types/node", "node"],
       "major": {
         "enabled": false
       },

tests-e2e/.nvmrc

@@ -0,0 +1 @@
+16.16.0

tests/issue-3095/test.spec.ts

@@ -0,0 +1,43 @@
+import { Directive } from '@angular/core';
+import { TestBed } from '@angular/core/testing';
+
+import { MockRender } from 'ng-mocks';
+
+class RecursiveDirective {}
+Directive({
+  selector: 'recursive',
+  providers: [
+    {
+      provide: RecursiveDirective,
+      useExisting: RecursiveDirective,
+    },
+  ],
+})(RecursiveDirective);
+
+@Directive({
+  selector: 'target',
+  providers: [
+    {
+      provide: RecursiveDirective,
+      useValue: null,
+    },
+  ],
+})
+class TargetDirective {}
+
+// When ng-mocks generates touches, it can meet recursions when a declaration provides itself in own providers.
+// In this case, ng-mocks shouldn't cause infinity loop.
+describe('issue-3095', () => {
+  beforeEach(() =>
+    TestBed.configureTestingModule({
+      declarations: [TargetDirective],
+    }).compileComponents(),
+  );
+
+  it('renders directive', () => {
+    const fixture = MockRender(TargetDirective);
+    expect(() =>
+      fixture.point.injector.get(RecursiveDirective),
+    ).not.toThrow();
+  });
+});

webpack.config.js

@@ -2,8 +2,8 @@ const path = require('node:path');
 
 module.exports = [
   {
-    mode: 'production',
-    devtool: 'source-map',
+    mode: process.env.MODE || 'production',
+    devtool: process.env.MODE ? false : 'source-map',
     entry: './libs/ng-mocks/src/index.ts',
     target: ['web', 'es3'],
     output: {
@@ -36,8 +36,8 @@ module.exports = [
     },
   },
   {
-    mode: 'production',
-    devtool: 'source-map',
+    mode: process.env.MODE || 'production',
+    devtool: process.env.MODE ? false : 'source-map',
     entry: './libs/ng-mocks/src/index.ts',
     target: ['web', 'es2015'],
     experiments: {