Fixed infinite loop when fetching multiple pages of consumers exist #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause seems to be the 'opt' variable being shadowed within the for loops. When a page of consumers is returned with an offset, the first page is requested again.
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hbagdi,
Found a bug when trying to sync APIs on a Kong instance with more than 1,000 consumers.
deckseem to have got into an infinite loop when dumping the consumers, fetching the first page of 1,000 consumers over and over again. I suspect that the issue was theoptvariable being shadowed within the for loops.Please take a look at this PR which fixes this for consumers, and should also fix it for the other entities (although I have not tested them). Please let me know what you think.
Thanks for the tool. It's been very helpful to us.
Regards,
Leon