Cloud Build - Add approval config

[rotilho]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Cloud Build added support to approvals and already released to their rest API as you can see here https://cloud.google.com/build/docs/api/reference/rest/v1/projects.triggers#BuildTrigger

New or Affected Resource(s)

• google_cloudbuild_trigger

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "filename-trigger" {
  trigger_template {
    branch_name = "master"
    repo_name   = "my-repo"
  }

  substitutions = {
    _FOO = "bar"
    _BAZ = "qux"
  }

  approval_required = true

  filename = "cloudbuild.yaml"
}

[simonkarman]

Any indication on if/when this will be added?

[parekhnaman]

Any update on feature release ?

[ismailsimsek]

Any update ?

[abhinavrau]

I would like to work on this issue. I have added support for it on my fork of magic-modules here. I will be submitting a PR soon

[wyardley]

Thanks again @abhinavrau (cc: @slevenick @shuyama1)

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.