Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform support for Cloud Composer's High Resilience Feature #14751

Closed

Comments

@Khaledmohamedrefaat
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add Terraform support for Cloud Composer's High Resilience Feature

New or Affected Resource(s)

google_composer_environment

References

#0000

@Khaledmohamedrefaat
Copy link
Author

I wish to work on this item.

@melinath
Copy link
Collaborator

@Khaledmohamedrefaat could you give an example of what the change would be to implement support for this feature? Is it just a new field on the resource?

@melinath
Copy link
Collaborator

looks like a new field, and this is a handwritten resource

@melinath
Copy link
Collaborator

It looks like this should already be supported in Terraform: https://cloud.google.com/composer/docs/composer-2/create-environments#terraform_4

@melinath
Copy link
Collaborator

It looks like despite being in the cloud.google.com docs, the resilience_mode field does not actually exist in the provider 😂

@Khaledmohamedrefaat
Copy link
Author

Hi @melinath, resilience_mode field has just been added to composer Go API, and we are submitting this pull request to make terraform support the use of this new field.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.