Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataproc HA to Non HA change doesnt rebuild cluster #11948

Closed
Labels
bug forward/review In review; remove label to forward service/dataproc

Comments

@krishna4ldw
Copy link

krishna4ldw commented Jun 24, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

$ terraform -v
Terraform v1.1.7
on windows_386

  • provider registry.terraform.io/hashicorp/google v4.8.0
  • provider registry.terraform.io/hashicorp/google-beta v4.26.0

Affected Resource(s)

google dataproc

  • google_dataproc_cluster

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.

Debug Output

Panic Output

Expected Behavior

when changing from HA to Non HA Dataproc cluster Terraform should prompt for replace i.e delete and create

Actual Behavior

terraform consider as change and it just try to update
which is not correct one

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@c2thorn
Copy link
Collaborator

c2thorn commented Jun 24, 2022

Does the resulting update fail? Do you have an example of the error?

@krishna4ldw
Copy link
Author

no update doesnt fail
Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
Modifications complete after 0s but cluster still has 3 masters

@krishna4ldw
Copy link
Author

Any update @c2thorn when can we expect this change ?

@c2thorn
Copy link
Collaborator

c2thorn commented Oct 20, 2022

@krishna4ldw sorry, this was lost. What field are you updating exactly?
If the update doesn't fail, does it result in a permanent diff on subsequent plans/applies?

I'm not an expert in Dataproc cluster specifically, so what does HA/Non HA mean here?

@krishna4ldw
Copy link
Author

krishna4ldw commented Oct 31, 2022

@c2thorn I am referring to this paramter
master_config {
num_instances = 1
}

Details num_instances = 3 is for HA
num_instances = 1 for non HA
Change in no of instances is not rebuilding dataproc cluster and no change in number of instances

@mustaFAB53
Copy link

mustaFAB53 commented Feb 23, 2023

Hi Team,

Do we have any updates on this issue?
Changing num_instances in master_config shows that the resource will be modified and completes successfully but actually the number of master nodes are still the same
It should actually recreate the cluster instead of modifying.

In gcloud CLI, update operation doesn't support updating master mode (HA / non-HA)

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
@github-actions github-actions bot added service/dataproc forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.