Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docker builder over to go-dockerclient #2809

Closed
markpeek opened this issue Oct 7, 2015 · 5 comments
Closed

Switch docker builder over to go-dockerclient #2809

markpeek opened this issue Oct 7, 2015 · 5 comments

Comments

@markpeek
Copy link
Collaborator

markpeek commented Oct 7, 2015

This is a placeholder issue to switch the docker code to use go-dockerclient which would clean up the existing code (e.g., the upload/download code). Due to needing more recent API changes (such as archive to copy from host to container) this would require updating the docker minimum requirement to 1.8+.

Related to: #901, #1752, #2436, #2581, #2675, #2697, #2807, #2832, #3102, #3222

@cbednarski
Copy link
Contributor

I'm starting on this for the docker communicator as part of the work on #2793. I don't plan to do it all at once.

@cbednarski
Copy link
Contributor

Current (updated) plan is to rewrite the docker bits in 0.11 to use go-dockerclient so we don't have to deal with this anymore. This should fix most of the problems people are having with the docker builder. This will break bc for some specific cases but I think overall this just makes more sense.

@rickard-von-essen rickard-von-essen removed this from the v0.11.0 milestone Oct 5, 2016
@jfusterm
Copy link

Hi @cbednarski , any plans to implement this anytime soon?

@rickard-von-essen
Copy link
Collaborator

rickard-von-essen commented Oct 26, 2016

@jfusterm I have started this work but it's progressing slowly, see #4186.

@mwhooker
Copy link
Contributor

mwhooker commented Jan 30, 2017

going to close and take care of in #4186

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants