Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Database] Add maxfee & validduration columns to t_transactions #333

Closed
wants to merge 9 commits into from

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Oct 22, 2019

Detailed description:
This changes adds the missing maxFee and validDuration columns from a transaction to the transactions table in the database.

Changes include

  • New flywaydb migration version for sql to alter the Postgres transactions table
  • Updated to the Transaction domain and Transactions objects in tests with the matching change
  • Update to RecordFileLogger sqlinserttransaction calls to set new columns

Which issue(s) this PR fixes:
Fixes #221

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Add maxfee & validduration columns to t_transactions

Signed-off-by: Nana Essilfie-Conduah <nana@hedera.com>
…hub.com/hashgraph/hedera-mirror-node into add-maxfee-validduration-totransactions

Signed-off-by: Nana Essilfie-Conduah <nana@hedera.com>
@Nana-EC Nana-EC added good first issue Good for newcomers database Area: Database labels Oct 22, 2019
@Nana-EC Nana-EC added this to the 0.4.0 milestone Oct 22, 2019
@Nana-EC Nana-EC added the P2 label Oct 22, 2019
@steven-sheehy steven-sheehy added the enhancement Type: New feature label Oct 22, 2019
…hub.com/hashgraph/hedera-mirror-node into add-maxfee-validduration-totransactions

Signed-off-by: Nana Essilfie-Conduah <nana@hedera.com>

Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #333 into master will increase coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #333      +/-   ##
============================================
+ Coverage     49.83%   49.89%   +0.05%     
  Complexity      414      414              
============================================
  Files            56       56              
  Lines          2735     2742       +7     
  Branches        373      373              
============================================
+ Hits           1363     1368       +5     
- Misses         1206     1208       +2     
  Partials        166      166
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/hedera/mirror/domain/Transaction.java 71.42% <0%> (-11.91%) 10 <0> (ø)
.../com/hedera/recordFileLogger/RecordFileLogger.java 61.63% <100%> (+0.41%) 56 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c6cbd...a78ccf4. Read the comment docs.

Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
…hub.com/hashgraph/hedera-mirror-node into add-maxfee-validduration-totransactions

Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
@Nana-EC Nana-EC force-pushed the add-maxfee-validduration-totransactions branch from 853726f to a78ccf4 Compare October 22, 2019 20:31
@Nana-EC Nana-EC closed this Oct 22, 2019
@steven-sheehy steven-sheehy deleted the add-maxfee-validduration-totransactions branch October 31, 2019 04:35
@steven-sheehy steven-sheehy removed this from the Mirror 0.4.0 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Area: Database enhancement Type: New feature good first issue Good for newcomers P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB Transactions: t_transactions table missing validDuration+MaxFee
2 participants