Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file transaction logger test coverage #316

Closed
gregscullard opened this issue Oct 15, 2019 · 0 comments · Fixed by #319
Closed

Improve file transaction logger test coverage #316

gregscullard opened this issue Oct 15, 2019 · 0 comments · Fixed by #319
Assignees
@gregscullard
Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc
Milestone
Mirror 0.4.0

Comments

@gregscullard
Copy link
Contributor

Detailed Description
Test coverage for file transactions logging is incomplete.

Actual Behavior
Run RecordFileLoggerFileTest and witness test coverage is incomplete.

Expected Behavior
Test coverage should be as complete as possible.

Environment:

  • Version: 0.3.0

Additional Context
Add any other context about the problem here. Attach any logs here, if applicable.
@gregscullard gregscullard added the bug Type: Something isn't working label Oct 15, 2019
@gregscullard gregscullard self-assigned this Oct 15, 2019
@gregscullard gregscullard mentioned this issue Oct 15, 2019
Merged
2 tasks
@gregscullard gregscullard added enhancement Type: New feature test Test infrastructure, automated tests required, etc and removed bug Type: Something isn't working labels Oct 16, 2019
@steven-sheehy steven-sheehy added this to the 0.4.0 milestone Oct 16, 2019
@apeksharma apeksharma mentioned this issue Oct 31, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregscullard gregscullard

Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc
Projects
None yet
Milestone
Mirror 0.4.0
Development

Successfully merging a pull request may close this issue.

316-Improved test coverage hashgraph/hedera-mirror-node
2 participants
@gregscullard @steven-sheehy