BUG/MAJOR: storage: don't clear the file on general file PUT

haproxytech · Dec 13, 2024 · bdac979 · bdac979
1 parent fecffd4
commit bdac979
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/handlers/general_storage.go b/handlers/general_storage.go
@@ -18,6 +18,7 @@ package handlers
 import (
 	"bufio"
 	"fmt"
+	"io"
 	"os"
 	"path/filepath"
 	"strings"
@@ -188,16 +189,10 @@ func (h *StorageReplaceStorageGeneralFileHandlerImpl) Handle(params storage.Repl
 		return storage.NewReplaceStorageGeneralFileDefault(int(*e.Code)).WithPayload(e)
 	}
 
-	file, ok := params.FileUpload.(*runtime.File)
-	if !ok {
+	data, err := io.ReadAll(params.FileUpload)
+	if err != nil {
 		return storage.NewReplaceStorageGeneralFileBadRequest()
 	}
-	data := []byte{}
-	if _, err := file.Read(data); err != nil {
-		e := misc.HandleError(err)
-		return storage.NewReplaceStorageGeneralFileDefault(int(*e.Code)).WithPayload(e)
-	}
-
 	_, err = gs.Replace(params.Name, string(data))
 	if err != nil {
 		e := misc.HandleError(err)