Skip to content

Commit

Permalink
Update: Remove isBuffer utility (ref #112)
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed Sep 27, 2016
1 parent 708f08e commit ddce456
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 38 deletions.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var clone = require('clone');
var cloneStats = require('clone-stats');
var cloneBuffer = require('./lib/cloneBuffer');
var removeTrailingSep = require('remove-trailing-separator');
var isBuffer = require('./lib/isBuffer');
var isBuffer = require('buffer').Buffer.isBuffer;

This comment has been minimized.

Copy link
@shinnn

shinnn Oct 3, 2016

Contributor

@phated Out of curiosity, why not just Buffer.isBuffer? Node.js automatically defines Buffer in the global scope.

This comment has been minimized.

Copy link
@phated

phated Oct 3, 2016

Author Member

Not sure. I think the global got added at some point. Maybe 0.10. I'd like to use the is-buffer module but feross is on an anti-node 0.10 rampage.

This comment has been minimized.

Copy link
@yocontra

yocontra Oct 3, 2016

Member

@phated Buffer global has been there since 0.4.x IIRC (maybe even earlier)

var isStream = require('is-stream');
var inspectStream = require('./lib/inspectStream');
var normalize = require('./lib/normalize');
Expand Down
1 change: 0 additions & 1 deletion lib/isBuffer.js

This file was deleted.

36 changes: 0 additions & 36 deletions test/is-buffer.js

This file was deleted.

0 comments on commit ddce456

Please sign in to comment.