Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a mutex instead of a lock for more efficient/simple locking #146

Merged
merged 1 commit into from
Oct 1, 2011
Merged

use a mutex instead of a lock for more efficient/simple locking #146

merged 1 commit into from
Oct 1, 2011

Conversation

f1sherman
Copy link
Contributor

I thought it might be easier to use a Mutex for the locking between the listener/interactor threads. Take a look and let me know what you think. Thanks for the awesome tool!

/Brian

@netzpirat netzpirat merged commit b3535b4 into guard:master Oct 1, 2011
@netzpirat
Copy link
Contributor

This is an excellent use of a Mutex and makes everything much simpler. Thank you very much!

@thibaudgg
Copy link
Member

Awesome, thanks!

@thibaudgg
Copy link
Member

Sadly it seems to have an issue with the mutex way. Interactor should be locked more aggressively (like before) don't you think?

@f1sherman
Copy link
Contributor Author

Good catch! I didn't anticipate that the interactor thread would continue to capture input from stdin, but it looks like that's what is happening. I'll be submitting another pull request for you momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants