Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--live-reload not passed on to nanoc view when invoked as nanoc live #38

Closed
moll opened this issue Jul 27, 2018 · 4 comments
Closed

--live-reload not passed on to nanoc view when invoked as nanoc live #38

moll opened this issue Jul 27, 2018 · 4 comments

Comments

@moll
Copy link

moll commented Jul 27, 2018

Hey,

From the output of --help, I believe nanoc live intended to pass its arguments to nanoc view, however for --live-reload it still throws an error about an illegal option. It's probably more future proof to pass unrecognized args all through as I'd probably forget to update nanoc live's opt parser as well if I were improving nanoc view. :P

@denisdefreyne
Copy link
Member

Hi,

nanoc live doesn’t pass options to nanoc view. It always has live-reloading enabled, so there’s no need to pass --live-reload.

Am I correct when I say that your confusion is caused by the following:

DESCRIPTION
    Starts the live recompiler along with the static web server. [snip]

If so, I think a better description might be

DESCRIPTION
    Starts the live recompiler, along with a web server with live-reloading enabled. [snip]

What do you think?

@denisdefreyne
Copy link
Member

Oh, my bad — I am confusing the nanoc live command provided by guard-nanoc and the nanoc live command provided by the nanoc-live gem (pre-release only for now).

Options are meant to be passed through, so this is indeed incorrect.

@denisdefreyne
Copy link
Member

This is fixed in 2.1.3, just released!

@moll
Copy link
Author

moll commented Jul 31, 2018

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants