Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why PR filed by CompatHelper do not trigger the CI pipeline? #527

Closed
fverdugo opened this issue Jan 26, 2021 · 4 comments
Closed

Why PR filed by CompatHelper do not trigger the CI pipeline? #527

fverdugo opened this issue Jan 26, 2021 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@fverdugo
Copy link
Member

@amartinhuertas can you help with this ?

@fverdugo fverdugo added the help wanted Extra attention is needed label Jan 26, 2021
@amartinhuertas
Copy link
Member

@amartinhuertas can you help with this ?

Yes, sure. I will come back to you when I have a solution ...

@amartinhuertas amartinhuertas self-assigned this Jan 27, 2021
@amartinhuertas
Copy link
Member

It seems that CompatHelper is not triggering the CI pipeline because there is a missing COMPATHELPER_PRIV record in the CompatHelper GitHub action yml file. Directly quoting from:

/~https://github.com/JuliaRegistries/CompatHelper.jl#12-set-up-the-ssh-deploy-key-optional

The default CompatHelper setup has one flaw: the pull requests that CompatHelper opens will not trigger any other GitHub Actions.

Consider the following situations:
You use GitHub Actions to test your package using continuous integration (CI).
You use GitHub Actions to build and deploy the documentation for your package.
If any of those situations apply to you, then you will need to set up an SSH deploy key for CompatHelper. Once you have set up an SSH deploy key for CompatHelper, the pull requests that CompatHelper opens will trigger all of the usual GitHub Actions.

Fixing it ...

@amartinhuertas
Copy link
Member

Handling this issue in PR #528

@amartinhuertas
Copy link
Member

It seems that CompatHelper is already triggering the CI pipeline, see, e.g., #540

Closing the issue ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants