-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Show panels within collapsed rows in dashboard picker #75490
Conversation
Hello @VikaCep!
Please, if the current pull request addresses a bug fix, label it with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-75490-to-v10.1.x origin/v10.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 14e94d663fdca4f90883cc9864bedd3719f04e88
# When the conflicts are resolved, stage and commit the changes
git add . && git cherry-pick --continue If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-75490-to-v10.1.x
# Create the PR body template
PR_BODY=$(gh pr view 75490 --json body --template 'Backport 14e94d663fdca4f90883cc9864bedd3719f04e88 from #75490{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v10.1.x] Alerting: Show panels within collapsed rows in dashboard picker" --body-file - --label "type/bug" --label "area/alerting" --label "area/frontend" --label "add to changelog" --label "backport" --base v10.1.x --milestone 10.1.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-75490-to-v10.1.x
# Create a pull request where the `base` branch is `v10.1.x` and the `compare`/`head` branch is `backport-75490-to-v10.1.x`.
# Remove the local backport branch
git switch main
git branch -D backport-75490-to-v10.1.x |
What is this feature?
Currently, when creating an alert rule and linking it to a dashboard and panel, the picker is not showing panels within collapsed rows. Additionally, it's listing rows as panels. This PR fixes that by allowing to choose from panels that are within collapsed rows and also filters out rows from the modal.
Why do we need this feature?
To be able to select panels within collapsed rows.
Who is this feature for?
All users
Which issue(s) does this PR fix?:
Fixes #75093