Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas: Fix inconsistent element placement when changing element type #74942

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

linghaoSu
Copy link
Contributor

@linghaoSu linghaoSu commented Sep 14, 2023

Which issue(s) does this PR fix?:

fix placement reset when change element type

Fixes #74941
Fixes #74222

result:

2023-09-15.00.41.17.mov

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@linghaoSu linghaoSu requested a review from a team as a code owner September 14, 2023 16:44
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/frontend pr/external This PR is from external contributor labels Sep 14, 2023
@nmarrs nmarrs added this to the 10.2.x milestone Sep 21, 2023
@nmarrs nmarrs added add to changelog no-backport Skip backport of PR labels Sep 21, 2023
@nmarrs nmarrs changed the title Canvas: fix abnormal placement change when change element type Canvas: Fix inconsistent element placement when changing element type Sep 21, 2023
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one nit on fallback top / left of icon. Thanks for your contribution!

@nmarrs nmarrs self-assigned this Sep 21, 2023
@nmarrs nmarrs enabled auto-merge (squash) September 21, 2023 20:29
@nmarrs
Copy link
Contributor

nmarrs commented Sep 21, 2023

Hi @linghaoSu - to fix the build I believe we need to rebase your PR branch onto latest main. As I do not have write permissions to your branch you will need to first pull latest main branch, switch to your PR branch and run git merge origin main and push.

Thanks!

@nmarrs nmarrs merged commit b5da762 into grafana:main Sep 21, 2023
@linghaoSu linghaoSu deleted the fix/canvas-placement-changed branch September 22, 2023 00:14
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
4 participants