SSE: Reduce to apply Mode to instant vector (mathexp.Number) #74859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
added
add to changelog
area/expressions
yuri-tceretian
commented
Sep 13, 2023
| Text: fmt.Sprintf("Reduce operation is not needed. Input query or expression %s is already reduced data.", gr.VarToReduce), | ||
| }) | ||
| copyV.SetValue(value) | ||
| if gr.seriesMapper == nil { |
There was a problem hiding this comment.
I think this is semantically correct because in this case reduce is not a noop anymore.
kylebrandt
reviewed
Sep 14, 2023
| require.Equal(t, expectedValue, actualValue) | ||
| } | ||
|
|
||
| t.Run("should add warn notices to every frame", func(t *testing.T) { |
There was a problem hiding this comment.
We should see if works with only the first frame, and if it does only put it there. Else were could be repeating this string a lot if there are many items in the response.
There was a problem hiding this comment.
I can address it in a follow-up PR.
kylebrandt
approved these changes
Sep 14, 2023
3 tasks
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Updates reduce command expression to apply modes
DropandReplaceto mathexp.Number.Also, it changes when the warning is returned. If mapping mode is not Strict, the warning will not be added.
Why do we need this feature?
Initially, the expression applied this mode to mathexp.Series (i.e. time-series). However, from user's perspective, the format of data may not be clear and the expression behavior looks different.
Who is this feature for?
Alerting users that query data sources that return vectors and want to drop\map non-numeric values.
Which issue(s) does this PR fix?:
Fixes #74645
Special notes for your reviewer:
Please check that: