Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove unused/deprecated method #74485

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Chore: Remove unused/deprecated method #74485

merged 2 commits into from
Sep 19, 2023

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Sep 6, 2023 •
edited
Loading

What is this feature?

Removes the datasource getHighlighterExpression -- that was deprecated in 8.2.0

@ryantxu ryantxu requested review from a team as code owners September 6, 2023 17:53
@ryantxu ryantxu requested review from L-M-K-B, eledobleefe and jackw and removed request for a team September 6, 2023 17:53
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@github-actions github-actions bot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Sep 6, 2023
@ryantxu ryantxu added no-backport Skip backport of PR add to changelog labels Sep 6, 2023
sunker
sunker approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryantxu ryantxu merged commit e830543 into main Sep 19, 2023
@ryantxu ryantxu deleted the remove-old-method branch September 19, 2023 17:51
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunker sunker sunker approved these changes

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@jackw jackw Awaiting requested review from jackw jackw is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
add to changelog area/frontend levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryantxu @sunker @zerok