Auth: Respect cache control for JWKS in auth.jwt #68872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jguer
requested review from
eleijonmarck and
kalleep
and removed request for
a team
grafanabot
added
area/backend
type/docs
IevaVasiljeva
approved these changes
May 23, 2023
| client: &http.Client{}, | ||
| url: urlStr, | ||
| log: s.log, | ||
| client: &http.Client{ |
There was a problem hiding this comment.
question: just curious about why you had to specify these? Which of the default values had to be changed?
There was a problem hiding this comment.
I did not need to specify, but it's best practice to configure timeouts and the transport (ProxyFromEnv). I got the defaults from some of our other services, actually missing an exported "NewHTTPClient(timeout duration) *http.Client" somewhere
There was a problem hiding this comment.
So it's mostly to be explicit about the timeouts etc? That makes sense, thanks for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Which issue(s) does this PR fix?:
Fixes #63465
Special notes for your reviewer:
Please check that: