AzureMonitor: Support multi-resource aliases and subscription aliases #68648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add subscription response type - Update AzureMonitorQuery type - Update docs - Update tests - Add function to retrieve subscription display name if not present
aangelisc
requested review from
bossinc and
alyssabull
and removed request for
a team
grafanabot
added
area/backend
datasource/Azure
|
Backend code coverage report for PR #68648
|
|
Frontend code coverage report for PR #68648 |
bossinc
approved these changes
May 18, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
grafanabot
added
the
backport-failed
aangelisc
removed
the
backport-failed
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-68648-to-v10.0.x origin/v10.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x bca8428f639613e35e9ad61728e0f11841d6b6ad
# Push it to GitHub
git push --set-upstream origin backport-68648-to-v10.0.x
git switch main
# Remove the local backport branch
git branch -D backport-68648-to-v10.0.xThen, create a pull request where the |
grafanabot
added
the
backport-failed
aangelisc
added a commit
that referenced
this pull request
May 23, 2023
…on aliases (#68823) AzureMonitor: Support multi-resource aliases and subscription aliases (#68648) Update legend aliases - Add subscription response type - Update AzureMonitorQuery type - Update docs - Update tests - Add function to retrieve subscription display name if not present (cherry picked from commit bca8428)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for two things:
New functionality has been added to retrieve the subscription name based off of the subscription ID to avoid running a migration in the front-end. These requests are efficient and are only executed if the display name is not already available to the datasource instance.
Legend aliases are now based on the current resource (based on the resource URI) rather than relying on just the ID returned in the series.
Fixes grafana/support-escalations#5920
Fixes grafana/support-escalations#5964