-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert: Allow editors to access GET /datasources #68632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5a830c4.
IevaVasiljeva
approved these changes
May 17, 2023
grafanabot
pushed a commit
that referenced
this pull request
May 17, 2023
grafanabot
pushed a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
backport v9.4.x
Mark PR for automatic backport to v9.4.x
backport v9.5.x
Bot will automatically open backport PR
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5a830c4.
why/what
During a escalation the API endpoint was downgraded from admin to editor. This reverts this change as it was part of a implementation that the dashboard team made to call the API during a new dashboard. This has been removed from their team /~https://github.com/grafana/support-escalations/issues/5900#issuecomment-1551301789 and we can upgrade the permissions back again to admin