DarkTheme: Fix dark theme shadows #68358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
ashharrison90,
eledobleefe and
mckn
and removed request for
a team
torkelo
added
backport v10.0.x
product-approved
torkelo
requested review from
JoaoSilvaGrafana,
staton-hyse11,
a team and
amy-super
academo
approved these changes
May 12, 2023
grafanabot
pushed a commit
that referenced
this pull request
May 17, 2023
* DarkTheme: Fix dark theme shadows * Update (cherry picked from commit 37791e7)
torkelo
added a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that our z1 and z2 shadows are completely invisible in the dark theme
Compared to light theme:
I have no memory of being like this when we launched new themes in v8 but it looks like it according to github history, so pretty confused :)
This means tooltips have no shadows in dark theme (and buttons and some other elements have no hover shadow)
This PR proposes some z1-2 shadows that try to match the light theme shadows.
Tooltip:
The z1 shadow on hover for buttons is barely visible still (But helps a little bit)
We don't use z2 that much (probably because it was invisible in dark theme).
One place I found is the auto complete popup for data links
Anyway. Happy to change it to something else but invisible like they are now I think is some kind of mistake :)