Loki: Enable dataplane-compliant metric data by default #67137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafanabot
added
area/backend
type/docs
gabor
requested review from
mildwonkey,
suntala and
yangkb09
and removed request for
a team,
mildwonkey,
suntala and
yangkb09
gabor
force-pushed
the
gabor/loki-metric-dataplane
branch
from
a2d466b to
3f37cbd
Compare
svennergr
approved these changes
Apr 24, 2023
gabor
force-pushed
the
gabor/loki-metric-dataplane
branch
from
3f37cbd to
2c57bf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the feature-flag enabled by default, the dataframes emitted by the loki datasource plugin will be compliant with the TimeSeriesMulti dataplane format.
the change this causes is fairly minimal, we do not expect many problems, but it is an observable change in the format, so it is a breaking change. affected users can disable the feature-flag to return to the previous behavior. at a certain point in the future, the feature-flag will be removed and it will not be possible to switch back to the "old" format.
Release notice breaking change
The data-format used by the Loki data source for metric (graph producing) queries was changed to be compliant with the recommended Grafana format. The change is very small, we do not expect it to cause problems: for instant-queries the dataframe-type changed from
timeseries-multitonumeric-multi, the dataframe-name attribute is not used anymore. If you are affected by this, you can revert back to the old format by setting the feature flaglokiMetricDataplanetofalse. We recommend migrating to the new format, because the feature-flag will be removed at some point in the future.