Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: Update required database version to 7.16 #66928

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Apr 20, 2023

Our supported-versions policy for Elasticsearch is: we support Elasticsearch versions that Elasticsearch-the-company supports.

the current info can be found at: https://www.elastic.co/support/eol

the support for elastic 7.15.x ended at 2023-03-22, so we will only support versions 7.16.x or higher.

(NOTE: the way this works is: you will still be able to use an older version of elasticsearch, but you will get warnings in the query-editor and in the datasource-config if you run an unsupported elasticsearch version)

(fixes #65908)

Release notice breaking change

Grafana requires an Elasticsearch version of 7.16 or newer. If you use an older Elasticsearch version, you will get warnings in the query editor and on the datasource configuration page.

@gabor gabor added this to the 10.0.0 milestone Apr 20, 2023
@gabor gabor requested a review from ivanahuckova April 20, 2023 09:57
@gabor gabor requested review from a team, Eve832 and GrafanaWriter as code owners April 20, 2023 09:57
@grafanabot grafanabot added area/frontend type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project labels Apr 20, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #66928
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #66928

Plugin Main PR Difference
elasticsearch 78.43% 78.43% 0%

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. Do we want to mark it as breaking change? 🤔

@gabor
Copy link
Contributor Author

gabor commented Apr 20, 2023

@ivanahuckova :

Nice! LGTM. Do we want to mark it as breaking change? 🤔

hmm.. good point, i don't know:

  • pro:
    • it is technically a change. people will get a warning-box where they did not get it before.
    • if we are unsure, it's better to mention it instead of not mentioning it
  • con:
    • nothing breaks, you only get a red warning-box above your query-builder
    • we did not change the "support what is not end-of-life" policy, so this is not even a "change" as such

need to think a bit more about this 😄

@gabor gabor added the breaking change Relevant for changelog generation label Apr 21, 2023
@gabor gabor merged commit 53d5a99 into main Apr 21, 2023
@gabor gabor deleted the gabor/elastic-update-requirements branch April 21, 2023 11:37
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend breaking change Relevant for changelog generation datasource/Elasticsearch no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticsearch: update the minimal-required-version to what elastic-the-company supports
4 participants