This repository has been archived by the owner on Nov 9, 2021. It is now read-only.
Added node_modules exclude for PHPCS #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2019
|
Theme linting to be implemented in the scaffold - govCMS/govcms8-scaffold#12 |
|
I'm re-opening this as it has been a year and the other PR has not been merged, yet all new SaaS projects are still getting this issue. We need to fix the lint script in this repo as well as in ovCMS/govcms8-scaffold. |
|
Closing in favour of #455 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated phpcs.xml to exclude node_modules in the custom theme.
This PR should be merged (or declined) together with #222