Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While a sheet with default backdrop is closing and spam clicking the backdrop, snapTo no longer works. #321

Closed
zpv opened this issue Mar 4, 2021 · 0 comments · Fixed by #322
Closed

While a sheet with default backdrop is closing and spam clicking the backdrop, snapTo no longer works. #321

zpv opened this issue Mar 4, 2021 · 0 comments · Fixed by #322
Assignees
@gorhom
Labels
bug Something isn't working v2 Written in Reanimated v1

Comments

@zpv
Copy link

zpv commented Mar 4, 2021

Bug

If you have the first snapPoint to be 0 and use the BottomSheetBackdrop component, there's a bug which prevents snapTo/expand from working.

Environment info

Library Version
@gorhom/bottom-sheet 2.2.2
react-native 0.61.10
react-native-reanimated 1.13.2
react-native-gesture-handler 1.9.0

Steps To Reproduce

  1. Modify the example app's BackdropExample.tsx to have the first snapPoint to be 0. e.g
    image
  2. Navigate to Backdrop example.
  3. Spam press the backdrop.
  4. Sheet no longer responds to expand/snap actions.

Describe what you expected to happen:

  1. Should snap/expand.
Screen.Recording.2021-03-03.at.9.02.23.PM.mov

Reproducible sample code
@zpv zpv added the bug Something isn't working label Mar 4, 2021
@zpv zpv changed the title After closing sheet with default backdrop and spam clicking the backdrop while closing, snapTo no longer works. While a sheet with default backdrop is closing and spam clicking the backdrop, snapTo no longer works. Mar 4, 2021
@gorhom gorhom self-assigned this Mar 4, 2021
@gorhom gorhom added the v2 Written in Reanimated v1 label Mar 4, 2021
@gorhom gorhom mentioned this issue Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorhom gorhom

Labels
bug Something isn't working v2 Written in Reanimated v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent closing when sheet is out of screen gorhom/react-native-bottom-sheet
2 participants
@gorhom @zpv