Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default backdrop customization. #206

Closed
f-ricci opened this issue Jan 16, 2021 · 5 comments · Fixed by #212
Closed

Enable default backdrop customization. #206

f-ricci opened this issue Jan 16, 2021 · 5 comments · Fixed by #212
Labels
enhancement New feature or request v2 Written in Reanimated v1 v3 Written in Reanimated v2

Comments

@f-ricci
Copy link

f-ricci commented Jan 16, 2021

Feature Request

Enable background color customization on the default backdrop

Why it is needed

Most cases you don't need to make anything custom other than the background color. Copying and pasting the internal solutions doesn't seem elegant.

Possible implementation

here

you need to swap the order in the array, thus allowing the given styles to include the backgroundColor.

Code sample

const containerStyle = useMemo(
    () => [
      styles.container,
      style,
      {
        opacity: animatedOpacity,
      },
    ],
    [style, animatedOpacity]
  );
@f-ricci f-ricci added the enhancement New feature or request label Jan 16, 2021
@gorhom gorhom added v2 Written in Reanimated v1 v3 Written in Reanimated v2 labels Jan 17, 2021
@f-ricci
Copy link
Author

f-ricci commented Jan 19, 2021

Thanks @gorhom

@gorhom
Copy link
Owner

gorhom commented Jan 21, 2021

this should be resolved with v2.0.5 & v3.2.1 🎉

@hanselabreu
Copy link

It's as @vicolsson said. Didn't know we had an issue for this, I had opened a discussion (#431) thinking I was doing something wrong.

@hanselabreu
Copy link

Opened #448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 Written in Reanimated v1 v3 Written in Reanimated v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants