Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onCameraMove, onCameraIdle, onCameraMoveStarted methods on GoogleMapsMapView widget #292

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: onCameraMove, onCameraIdle, onCameraMoveStarted methods on GoogleMapsMapView widget #292

merged 1 commit into from
Feb 27, 2025

Conversation

jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Feb 27, 2025 •
edited
Loading

Fixes onCameraMove, onCameraIdle, onCameraMoveStarted methods on GoogleMapsMapView widget.

Fixes #287

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

@jokerttu jokerttu force-pushed the fix/camera-events-for-mapview branch from 6d2c231 to dffd5f3 Compare February 27, 2025 13:33
@jokerttu jokerttu marked this pull request as ready for review February 27, 2025 13:38
@jokerttu jokerttu requested a review from caio1985 February 27, 2025 13:38
@jokerttu jokerttu force-pushed the fix/camera-events-for-mapview branch from dffd5f3 to b0e074f Compare February 27, 2025 13:55
@ArturoSalazarB16 ArturoSalazarB16 self-assigned this Feb 27, 2025
@ArturoSalazarB16 ArturoSalazarB16 self-requested a review February 27, 2025 17:38
@jokerttu jokerttu merged commit d6aaa0d into main Feb 27, 2025
14 of 15 checks passed
@jokerttu jokerttu deleted the fix/camera-events-for-mapview branch February 27, 2025 18:15
@googlemaps-bot googlemaps-bot mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoSalazarB16 ArturoSalazarB16 ArturoSalazarB16 approved these changes

@caio1985 caio1985 Awaiting requested review from caio1985

Assignees

@caio1985 caio1985

@ArturoSalazarB16 ArturoSalazarB16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: onCameraMove, onCameraIdle, onCameraMoveStarted methods not working in the GoogleMapsMapView widget.
3 participants
@jokerttu @ArturoSalazarB16 @caio1985