fix: plumb list blobs match glob option for grpc transport (#2759)

googleapis · Oct 8, 2024 · 207abd1 · 207abd1
1 parent 88b3f62
commit 207abd1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java
@@ -1228,8 +1228,7 @@ private MatchGlob(String val) {
 
     @Override
     public Mapper<ListObjectsRequest.Builder> listObjects() {
-      return CrossTransportUtils.throwHttpJsonOnly(
-          com.google.cloud.storage.Storage.BlobListOption.class, "matchGlob(String)");
+      return b -> b.setMatchGlobBytes(ByteString.copyFromUtf8(val));
     }
   }
 

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITObjectTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITObjectTest.java
@@ -563,7 +563,6 @@ public void testListBlobsCurrentDirectoryIncludesBothObjectsAndSyntheticDirector
 
   @Test
   // When gRPC support is added for matchGlob, enable this test for gRPC.
-  @Exclude(transports = Transport.GRPC)
   public void testListBlobsWithMatchGlob() throws Exception {
     BucketInfo bucketInfo = BucketInfo.newBuilder(generator.randomBucketName()).build();
     try (TemporaryBucket tempBucket =