-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RRM product ID notifications #10069
Comments
AC ✅ |
Thank you for drafting the IB, @hussain-t!
As far as I can recall, components using the new notifications infrastructure should not return Let me know what you think, thank you! |
Thanks, @nfmohit! That sounds good. I've updated the IB. |
Looks great now, thank you @hussain-t! IB ✅ |
QA Update: ✅Verified:
Tested to ensure that the notifications only appeared when the trigger conditions are met and the v2 RRM feature flag is enabled. Also, tested In other scenarios, i.e. when no product ID is attached to the subscription and contribution then the notifications does not appear. The notifications were dismissed when the Note: I clicked on the Edit settings CTA button but at this stage, I am unable to edit the product ID, this will be tested more when 10065 is merged. |
Feature Description
With the addition of support for product IDs in Reader Revenue Manager as part of Phase 2, the Site Kit dashboard should show a notification recommending users to set a default product ID in Site Kit if it is available and not already set.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
paymentOption
issubscriptions
orcontributions
).productIDs
is not empty).paymentOption
issubscriptions
.paymentOption
iscontributions
.rrmModuleV2
feature flag is enabled.Implementation Brief
Create
ProductIDNotification
componentIn
assets/js/modules/reader-revenue-manager/components/dashboard
:ProductIDNotification
with the following:getPublicationOnboardingState
selector.paymentOption
from thegetPaymentOption
selector.productIDs
from thegetProductIDs
selector.productID
from thegetProductID
selector.productID
is not set:paymentOption
as described in the AC.Notification
component and theSubtleNotification
component as the child component.contributions
variant and pass it to theSubtleNotification
component based on the condition.getAdminURL
selector andnavigateTo
action.dismissItem
action.title
anddescription
as props to theSubtleNotification
component.Register
ProductIDNotification
componentIn
assets/js/modules/reader-revenue-manager/index.js
:ProductIDNotification
component within theNOTIFICATIONS
object with the following:product-id-notification-rrm
ProductIDNotification
RRMSetupSuccessSubtleNotification
component.checkRequirements
property that returnstrue
if the notification should be displayed:rrmModuleV2
feature flag is enabled.paymentOption
issubscriptions
orcontributions
.productIDs
is not empty.RRMSetupSuccessSubtleNotification
component should be dismissed.false
.Test Coverage
ProductIDNotification
component.QA Brief
rrmModule
andrrmModuleV2
feature flags enabled.Changelog entry
The text was updated successfully, but these errors were encountered: