You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have used howler v1.1.25 and when migrating to v2.02 we get this issue and script broke.
Older version load method did not call:
// Check if this extension is available.if(Howler.codecs(ext)){url=self._src[i];break;}
and everything is working fine.
New script is calling Howler.codecs with extension and if in some case invalid file without any extension is passed to script javascript will stop executing. I think script should not break javascript it should be more robust and I suggest inserting check if extension exists:
/** * Check for codec support of specific extension. * @param {String} ext Audio file extention. * @return {Boolean} */codecs: function(ext){if(ext){return(this||Howler)._codecs[ext.replace(/^x-/,'')];}},
Please let me know what do you think about this?
Thanks,
Adnan
The text was updated successfully, but these errors were encountered:
Hi,
We have used howler v1.1.25 and when migrating to v2.02 we get this issue and script broke.
Older version load method did not call:
and everything is working fine.
New script is calling Howler.codecs with extension and if in some case invalid file without any extension is passed to script javascript will stop executing. I think script should not break javascript it should be more robust and I suggest inserting check if extension exists:
Please let me know what do you think about this?
Thanks,
Adnan
The text was updated successfully, but these errors were encountered: