Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clojusc/protobuf instead of org.flatland/protobuf for default middleware #144

Closed
fr33m0nk opened this issue Feb 19, 2020 · 3 comments
Closed

Comments

@fr33m0nk
Copy link

fr33m0nk commented Feb 19, 2020

clojusc/protobuf project picked up the Clojure protobuf code base from the ghaskins fork which in turn is a fork of the original but no longer maintained project and has the fix for enums as Clojure keywords amongst many other enhancements.

This removes the need of using any workaround to handle enum declared in protobuf for publishing. Since Ziggurat already offers a default middleware that uses the older protobuf library, updating dependency and code once would be a great solution.

@fr33m0nk fr33m0nk changed the title Use clojusc/protobuf instead of org.flatland/protobuf Use clojusc/protobuf instead of org.flatland/protobuf for default middleware Feb 19, 2020
@fr33m0nk
Copy link
Author

fr33m0nk commented Feb 19, 2020

Please do let me know if I need to update the PR with bumped up version of Ziggurat in project.clj and the change-log

@theanirudhvyas
Copy link
Contributor

Hey @fr33m0nk, thanks for the PR. Have you tested the PR to verify that it is backward compatible with the previous version, i.e. the contract of the middleware hasn't changed?

@fr33m0nk
Copy link
Author

fr33m0nk commented Apr 9, 2020

Hey @theanirudhvyas ,

Apologies for the delayed reply.

Yeah, I have tested the changes and it indeed is backward compatible.
Middleware contract remains intact and people using this middleware would not be negatively affected if they upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants