Skip to content

Commit

Permalink
github: Try to fix "no space left on device" on MacOS
Browse files Browse the repository at this point in the history
  • Loading branch information
bep committed Aug 31, 2024
1 parent 6d97ee7 commit 96afea4
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
go-version: [1.22.x, 1.23.x]
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, windows-latest] # macos disabled for now because of disk space issues.
runs-on: ${{ matrix.os }}
steps:
- if: matrix.os == 'ubuntu-latest'
Expand Down
14 changes: 13 additions & 1 deletion magefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,11 @@ func Check() {
fmt.Printf("Skip Test386 on %s and/or %s\n", runtime.GOARCH, runtime.GOOS)
}

mg.Deps(Fmt, Vet)
if isCi() && isDarwin() {
// Skip on macOS in CI (disk space issues)
} else {
mg.Deps(Fmt, Vet)
}

// don't run two tests in parallel, they saturate the CPUs anyway, and running two
// causes memory issues in CI.
Expand Down Expand Up @@ -239,6 +243,14 @@ func Lint() error {
return nil
}

func isCi() bool {
return os.Getenv("CI") != ""
}

func isDarwin() bool {
return runtime.GOOS == "darwin"
}

// Run go vet linter
func Vet() error {
if err := sh.Run(goexe, "vet", "./..."); err != nil {
Expand Down

0 comments on commit 96afea4

Please sign in to comment.