Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for selecting game language #8

Open
Mixaill opened this issue Jun 23, 2019 · 1 comment
Open

Add support for selecting game language #8

Mixaill opened this issue Jun 23, 2019 · 1 comment

Comments

@Mixaill
Copy link
Contributor

Mixaill commented Jun 23, 2019 •
edited
Loading

It would be nice if GOG galaxy 2.0 would support game localization control.

Proposed changes in API:

  • LocalGame

    • Add field local_game_language: str

  • Game

    • Change game_title:str to game_title: Dict[str,str]
    • Add field game_languages: List[str]

  • Plugin

    • Add function set_game_language(self, game_id : str, language_code: str)
    • Change async def install_game(self, game_id: str): to async def install_game(self, game_id: str, language_code: str = None)

language_code should be ISO 3166 Alpha-2 (en, be, uk, pl) or BCP-47 (pt_BR)
@Mixaill Mixaill mentioned this issue Jun 28, 2019
Open
@apawlowskij
Copy link
Contributor

We will consider this in the future updates. Thank you for you feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mixaill @apawlowskij